yuanyan/halogen

RiseLoader throws DomException on iOS (5) Safari

Opened this issue · 1 comments

Hi,

I just found a small CSS typo that crashes halogen on iOS Safari.
See the code below:

/**
 * @type {Object}
 */
var keyframesEven = {
    '0%': {
        transform: 'scale(1.1)'
    },
    '25': { // <----------------------- Percent sign missing (causes DOM exception)
        transform: 'translateY(-' + riseAmount + 'px)'
    },
    '50%': {
        transform: 'scale(0.4)'
    },
    '75%': {
        transform: 'translateY(' + riseAmount + 'px)'
    },
    '100%': {
        transform: 'translateY(0) scale(1.0)'
    }
};

/**
 * @type {Object}
 */
var keyframesOdd = {
    '0%': {
        transform: 'scale(0.4)'
    },
    '25': { // <----------------------- Percent sign missing (causes DOM exception)
        transform: 'translateY(' + riseAmount + 'px)'
    },
    '50%': {
        transform: 'scale(1.1)'
    },
    '75%': {
        transform: 'translateY(-' + riseAmount + 'px)'
    },
    '100%': {
        transform: 'translateY(0) scale(0.75)'
    }
};

Once I add the percent signs, the error is fixed.

Regards

hi. just FYI, it's fixed in halogenium, the maintained halogen fork. also #24 fixed too. rendering in chrome/opera/firefox fixed too.