yuki24/artemis

Rake task name collision (almost)

Opened this issue · 0 comments

I noticed that artemis adds a new rake task: graphql:schema:update. This could be potentially dangerous because graphql gem adds graphql:* rake tasks:

rails graphql:pro:validate[gem_version] # Get the checksum of a graphql-pro version and compare it to published versions on GitHub and graphql-ruby.org
rails graphql:schema:dump               # Dump the schema to JSON and IDL
rails graphql:schema:idl                # Dump the schema to IDL in ./schema.graphql
rails graphql:schema:json               # Dump the schema to JSON in ./schema.json

For a gem called graphql, it makes sense to use graphql namespace. For artemis, I'd suggest you add an artemis namespace: artemis:*.

In this concrete example, perhaps the rake task would be: artemis:update_graphql_schema (or any other that you see fit).

https://github.com/yuki24/artemis#rake-tasks