Inquiry on BIOS, ECP version of your T490 in README.md

[jaejunh]

First of all, thank you very much for great porting on T490. I just owned a T490s (i7-8565u).
T490s, as you know, is light sibling of T490, and most of the hardware specs are very similar.

Having said that, when I tried you use your T490 opencore EFI in this project, it couldn't boot
with your patched frame buffer parameters in DeviceProperty. If I only keep
(ig-platform-id, device-id) of (0x0900A53E, 0xA53E0000) or (0x00009B3E, 0x9B3E0000) like:

		<key>PciRoot(0x0)/Pci(0x2,0x0)</key>
		<dict>
			<key>AAPL,ig-platform-id</key>
			<data>
			CQClPg==
			</data>
			<key>device-id</key>
			<data>
			pT4AAA==
			</data>
			<key>framebuffer-fbmem</key>
			<data>
			AACQAA==
			</data>
			<key>framebuffer-patch-enable</key>
			<data>
			AQAAAA==
			</data>
			<key>framebuffer-stolenmem</key>
			<data>
			AAAwAQ==
			</data>
		</dict>

most of the system works. So my mission is to find out why T490s is slightly different from T490.

So here comes my questions:

1. Are your BIOS and ECP versions : 0.1.66 and 0.1.9 which are different from https://support.lenovo.com/us/en/downloads/ds539061
   (Normally without appending 0. in version. Btw, mine are 1.65 and 1.17 )

2. Most of the T490s catalina 10.15.6(or .7) works for daily life as yours (thanks to you)
   However, my thunderbolt controller is listed as a combined/single XHC from USB porting mapping of Hackintool.
   Is this normal? I have no idea, but I suspect it's not the right way.
   Immediate consequence is that when my lenovo thunderbolt 3 dock is connected type-c port near ethernet port (dock portion) it cannot display well my HDMI monitor attached to dock. If I connect my thunderbolt 3 dock to the other type-c port, it works.
   Is this same for you?

3. Back to manual frame buffer patching, above ig-platform-id usually has 3 ports. But we have 4 possible ports,
   LVSD, Type-C, Thunderbolt Type-C, HDMI. Is there anyway I can block one of Type-C but save HDMI port? How is your configuration?

Thanks.

[yusifsalam]

Hi!

1. They are the same. I'm not sure where I got the 0s from, if I remember right I got the version numbers directly from the BIOS itself.
2. I'm not really sure to be honest. I have my Thunderbolt disabled via BIOS, since I don't use it for anything (and I don't have the dock either). Maybe @denzilferreira can help with this? I could be wrong but isn't only one of those USB-C ports Thunderbolt? Have you tested on Windows or Linux?
3. I believe it's possible but again I don't have much experience with framebuffer patching I'm afraid. In Hackintool you can see in the "Connectors" tab, you could then set framebuffer-con-enable property to false for that connector in the generated patch, maybe that would do the trick?
   
   I also recommend you take a look at WhateverGreen manual if you haven't already
   https://github.com/acidanthera/WhateverGreen/blob/master/Manual/FAQ.IntelHD.en.md

[jaejunh]

Hi!

1. They are the same. I'm not sure where I got the 0s from, if I remember right I got the version numbers directly from the BIOS itself.

Thank you for quick reply and sharing this info!

2. I'm not really sure to be honest. I have my Thunderbolt disabled via BIOS, since I don't use it for anything (and I don't have the dock either). Maybe @denzilferreira can help with this? I could be wrong but isn't only one of those USB-C ports Thunderbolt? Have you tested on Windows or Linux?
   Why didn't I think of that? That explains a few things. Let me try disabling my thunderbolt too temporarily. That could solve many things including frame buffer patching.

3. I believe it's possible but again I don't have much experience with framebuffer patching I'm afraid. In Hackintool you can see in the "Connectors" tab, you could then set framebuffer-con-enable property to false for that connector in the generated patch, maybe that would do the trick?
   I will also update on this approach too when I get my result.

I also recommend you take a look at WhateverGreen manual if you haven't already
https://github.com/acidanthera/WhateverGreen/blob/master/Manual/FAQ.IntelHD.en.md

Actually I read multiple times (although I am not that knowledgeable on this), but I guess reading once more might enlightened me. Thank you

[denzilferreira]

Hey, this is one of the things I still haven't figured out either. Currently, I have mine setup like this:

This works with my thunderbolt 3 dock, with my screen connected over HDMI to the dock and USB-C attached the laptop. If I use the default setup of the repo, I don't get audio out on the USB-C. Since I rather have my laptop connected with just one cable, this works the best for me.

[jaejunh]

Hey, this is one of the things I still haven't figured out either. Currently, I have mine setup like this:

This works with my thunderbolt 3 dock, with my screen connected over HDMI to the dock and USB-C attached the laptop. If I use the default setup of the repo, I don't get audio out on the USB-C. Since I rather have my laptop connected with just one cable, this works the best for me.

Hi, I think you might want to try this. It. basically enables 3 ports on motherboard, namely,
1-LVDS(BusID 0), 2. DP (TB Usb-C, BusID 5) 3. HDMI (BusID 2) on the laptop.

Above configuration will drop one of the usb-c port display near by lcd.
This gives me most freedom of connecting external displays.

I haven't check with TB3 Dock Gen 2 from Lenovo with this configuration yet. I will do that soon and let you know.

[denzilferreira]

I tried this. Findings:

• HDMI port: audio and video works
• USB-C port (closest to display): video works, no audio
• USB-C port (farthest from display): no video, no audio (basically the laptop keeps trying to connect to a display on a loop)

Close but not there yet 👍

[jaejunh]

I tried this. Findings:

• HDMI port: audio and video works
• USB-C port (closest to display): video works, no audio
• USB-C port (farthest from display): no video, no audio (basically the laptop keeps trying to connect to a display on a loop)

Hi, Denzilferreira,

Oh, let MacOS sleep and wake it up when you boot (just once). That's strange, but USB-C Port (farthest) works like a charm afterward! Side effect is HDMI port has to reconnected (which we already know).

Close but not there yet 👍

thank you for checking out! Just out of curiosity, do you have a dGPU with t490? In that case, adding hda-gfx parameter may be important.

There must be some differences in VGAs in our Thinkpads (my T490s has an internal uhd620 only) or something else.
For sure, I cannot boot with the frame buffer configuration with current setting from repository. With above configuration I shared with you, I am able to boot without problem and get audios (btw, my monitor is 1080p).
I think I will stick to my personal configuration 👍

thanks,

UPDATE: I experimented my current configuration and here are some results.

1. connect Samsung UHD monitor (without speaker?)
   1.1) UHD Monitor <-HDMI-> HDMI 1.4 on board port connected: 2560x1440 max resolution. Monitor didn't have speaker so don't know :(
   1.2) UHD Monitor <-HDMI-> Type-C DP-to-HDMI Adapter <-> TB Type-C port connected: 2560x1440 again.
   1.3) UHD Monitor <-HDMI-> Thinkpad Mechanical Dock <-> TB Type-C port connected: 2560x1440 again
   1.4) UHD Monitor <-DP-> Thinkpad Mechanical Dock <-> TB Type-C port connected: 2560x1440 again
   1.5) UHD Monitor <-DP-> Thinkpad Thunderbolt 3 Gen 2 Dock <->. .... Not tested yet (To be updated)

....

From above, it looks like I had to use your extra prameters like:

dpcd-max-link-rate =<14000000>
enable-dpcd-max-link-rate-fix =<01000000>

I will try those and let you know if that work at all.

[yusifsalam]

Closing due to inactivity