Representing Fetch' body concept in streams
annevk opened this issue · 13 comments
Aside from using enqueue, don't we also need to turn each mention of body into writable/readable stream pair?
The current fetch spec defines request body and response body as "byte streams" which I understand as byte sequences. Currently my draft does not change it but specifies bodies of type Readable[Byte]Stream in Body mixin. Do you intend to change that and move everything to the streams-based world?
In particular note how @yutakahirano's approach is to use the "response body" as a staging area for bytes before they are enqueued into the ReadableByteStream, as in e.g. the "To process response body for response, run these substeps" algorithm.
Aside from using enqueue, don't we also need to turn each mention of body into writable/readable stream pair?
I thought we had decided not to treat it as a writable stream. :-) Or maybe thats just my wishful thinking.
@yutakahirano well the Fetch stream-based world is streams that have both input and output simultaneously, similar to the Encoding Standard. I was thinking we needed to reconcile that somehow?
Maybe I am not understand something, but even if both bodies are a readable stream, there's an input side as well right? For Response that is the network or a service worker. For Request that is the window/worker? I was assuming that is some kind of writable stream we would need to model.
If just saying they are ReadableByteStream is enough, works form me.
Maybe I am not understand something, but even if both bodies are a readable stream, there's an input side as well right?
Yea, ok, but I think this "writable side" should be purely conceptual. For example, the Response.body stream will read directly from the disk. There is no pipe writing in that case.
I think it would be easiest to always specify the body as a ReadableStream. If the producer of a Response or Request needs to push data then their algorithm is written with a pipe. So Cache just sets a ReadableStream representing a file. The fetch algorithm creates a pipe, passes its Reader end as Response.body, and then enqueues to the writer end.
I'm not in a rush.
(Note that within this issue I was not talking about the body property from Request and Response. But about the abstract body concept attached to the abstract request and response concepts. Rereading I'm not sure that was clear.)
Shall we just close this issue?
Sure, let's discuss on branched threads.