Move PR template to .github folder

Question

Move PR template to .github folder

Closed this issue 4 years ago · 11 comments

Problem

Describe the problem related to this feature request.

When non-functional updates are brought to the library, it's not relevant to have the checklist about making sure that the library builds, that tests pass, and so forth.

Solution

What solution do you suggest to solve this problem?

Create a simpler template asking the user to describe the changes in the PR without the checklist.

Answer 1 · 2020-02-03T13:33:11.000Z

@yvesgurcan PR template as in a HTML template or just a .md template?

Answer 2 · 2020-02-03T19:51:59.000Z

@GlobeFire Absolutely! There is a Markdown template for PRs here: https://github.com/yvesgurcan/web-midi-player/blob/master/PULL_REQUEST_TEMPLATE. Unfortunately, it looks like it is not possible or desirable to have multiple PR templates in GitHub. Therefore, I suggest that you simply move the existing template inside the .github directory. What do you think?

Answer 3 · 2020-02-04T13:18:03.000Z

Hello @yvesgurcan , I am a first-timer contributor and would love to solve this issue. But, I am a little confused as to what I should do here. Or has the issue already been solved?

Answer 4 · 2020-02-05T14:30:44.000Z

hey, @theOpetunde you are welcome to solve the issue. I am looking for a solution. If you find it feel free to make the PR.

Answer 5 · 2020-02-05T14:35:16.000Z

@GlobeFire Absolutely! There is a Markdown template for PRs here: https://github.com/yvesgurcan/web-midi-player/blob/master/PULL_REQUEST_TEMPLATE. Unfortunately, it looks like it is not possible or desirable to have multiple PR templates in GitHub. Therefore, I suggest that you simply move the existing template inside the .github directory. What do you think?

Hey @yvesgurcan, sure sounds good. Just to make it clear, you are suggesting that https://github.com/yvesgurcan/web-midi-player/blob/master/PULL_REQUEST_TEMPLATE
this template should be pushed to the .github folder?

Answer 6 · 2020-02-07T00:09:32.000Z

Hey @GlobeFire and @theOpetunde,
Yes, since it is not possible to have multiple PR templates in GitHub, we can change the issue to simply moving ./PULL_REQUEST_TEMPLATE to .github/PULL_REQUEST_TEMPLATE. Feel free to fork the project and open a pull request to do that! I will update the title of the issue.

Answer 7 · 2020-02-07T11:15:11.000Z

@yvesgurcan Thank you for the explanation

Answer 8 · 2020-02-07T12:26:45.000Z

@theOpetunde since this is your first time, you make a PR.
@yvesgurcan is there any other issue I can work on?

Answer 9 · 2020-02-07T12:55:32.000Z

Thank you @GlobeFire. You're very kind

@yvesgurcan I have made a PR to solve the issue. Please check if I am correct and your feedback will be appreciated.

Answer 10 · 2020-02-07T17:39:39.000Z

Great job @theOpetunde! I've approved and merged your PR.

@GlobeFire, there's plenty to do! If you want to keep working on good first issues, you can always look here: https://github.com/yvesgurcan/web-midi-player/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22.

More specifically, you are more than welcome to open a PR for #47 or #38.

If you're feeling more adventurous and want to write some code in React, there's also #12 . Let me know if you need help running the example on your machine.

Answer 11 · 2020-02-12T14:34:14.000Z

Thanks @yvesgurcan, I would love to work on the react issue. I'll try to run the example if required I will ping you.