Data sources
shortthefomo opened this issue · 3 comments
Not a bug but a suggestion
- i would look at changing up some of the data sources compared with xumm
- there is value in having some over lap but your well over 50%
My suggestion is as follows.
- Bistamp and Kraken should def stay
- FTX is mostly a derivatives exchange, but they do have the one fiat pair (keep that in mind from its data) it a good outsider.
- Bitrue is USD via tether! It should have a lower weighting in the overall price, if you want to keep that in the price calculation.
- add Bitso, cryptocom I am waiting on the new coinsph websocket to launch when that pro exchange fires up that def should go in there.
- Lastly is phemex they provide most of the tech for all the fiat on ramps all exchanges use, this IMO is an important one.
Rocking.
Excellent suggestion! Thank you @lathanbritz
I should ultimately include an ADR but for context how I came up with the exchanges:
My methodology was to add some variance to the Oracle from Xumm while I took a few exchanges that had substantial volume for XRP.
I'm utilizing ccxt for convenience but for instance Bitrue isn't available in ccxt but has a public endpoint (without auth) that lets me grab the price.
In regards to FTX, as more of a derivatives exchange, was something I didn't consider. They do have volume but that would definitely be higher in a derivatives exchange.
In regards to using USDT pairs I think this is definitely something I want to drop. Like Xumm's Oracle, the USDT price is used I think for when there isn't a USD pair. Some exchanges had both and since I was looking for some average I probably naively thought it would be ok to include it if we're ultimately looking at the median of some results that don't drift far from the standard deviation of all the values.
I connect to all the XRP / Fiat sockets or REST if they not available. I can aid you in any of them if you choose to move away from that lib.
Yeah I fully understand the diversification needs.
On that not something to think around would be all those bridges. wan chain, flare, kava, might be another delta. Or fine grained, Oracle that also has value, esp for those auto mated DEX/on chain swoops... 👍🏻
I connect to all the XRP / Fiat sockets or REST if they not available. I can aid you in any of them if you choose to move away from that lib.
will definitely pick your brain after coming up with a list of exchanges!
On that not something to think around would be all those bridges. wan chain, flare, kava, might be another delta. Or fine grained, Oracle that also has value, esp for those auto mated DEX/on chain swoops... 👍🏻
now that's interesting :) I definitely want to include the XRPL DEX (yyolk/xrp-price-aggregate#18)
The prices from Kava, Wan, and upcoming FTSO oracles will be something to explore as well