Diff margin can crash Visual Studio
sharwell opened this issue · 1 comments
sharwell commented
Call stack:
Microsoft.VisualStudio.Platform.VSEditor.dll!Microsoft.VisualStudio.Text.Editor.Implementation.WpfTextView.Microsoft.VisualStudio.Text.Editor.IWpfTextView.GetTextViewLineContainingBufferPosition(Microsoft.VisualStudio.Text.SnapshotPoint bufferPosition) + 0x2fd bytes
GitSccProvider.dll!GitScc.Diff.ViewModel.DiffViewModel.UpdateDimensions(bool approximate, Microsoft.VisualStudio.Text.Editor.TextViewLayoutChangedEventArgs e) + 0x29a bytes
GitSccProvider.dll!GitScc.Diff.ViewModel.DiffViewModel.SetDisplayProperties(bool approximate, Microsoft.VisualStudio.Text.Editor.TextViewLayoutChangedEventArgs e) + 0x29 bytes
GitSccProvider.dll!GitScc.Diff.ViewModel.DiffMarginViewModel.RefreshDiffViewModelPositions(bool approximate = false, Microsoft.VisualStudio.Text.Editor.TextViewLayoutChangedEventArgs e = null) + 0x6c bytes
GitSccProvider.dll!GitScc.Diff.ViewModel.DiffMarginViewModel.RefreshDiffViewModelPositions() + 0x9 bytes
WindowsBase.dll!System.Windows.Threading.ExceptionWrapper.InternalRealCall(System.Delegate callback, object args, int numArgs) + 0xbd bytes
WindowsBase.dll!MS.Internal.Threading.ExceptionFilterHelper.TryCatchWhen(object source = {System.Windows.Threading.Dispatcher}, System.Delegate method, object args, int numArgs, System.Delegate catchHandler = null) + 0x3a bytes
WindowsBase.dll!System.Windows.Threading.DispatcherOperation.InvokeImpl() + 0xac bytes
WindowsBase.dll!System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(object state) + 0x38 bytes
mscorlib.dll!System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, object state, bool preserveSyncCtx) + 0xa7 bytes
mscorlib.dll!System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, object state, bool preserveSyncCtx) + 0x16 bytes
mscorlib.dll!System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, object state) + 0x41 bytes
WindowsBase.dll!System.Windows.Threading.DispatcherOperation.Invoke() + 0x5b bytes
WindowsBase.dll!System.Windows.Threading.Dispatcher.ProcessQueue() + 0x16b bytes
WindowsBase.dll!System.Windows.Threading.Dispatcher.WndProcHook(System.IntPtr hwnd, int msg, System.IntPtr wParam, System.IntPtr lParam, ref bool handled) + 0x5a bytes
WindowsBase.dll!MS.Win32.HwndWrapper.WndProc(System.IntPtr hwnd = 1383320, int msg = 49594, System.IntPtr wParam = 0, System.IntPtr lParam = 0, ref bool handled = false) + 0x9b bytes
WindowsBase.dll!MS.Win32.HwndSubclass.DispatcherCallbackOperation(object o) + 0x6b bytes
WindowsBase.dll!System.Windows.Threading.ExceptionWrapper.InternalRealCall(System.Delegate callback, object args, int numArgs) + 0x56 bytes
WindowsBase.dll!MS.Internal.Threading.ExceptionFilterHelper.TryCatchWhen(object source = {System.Windows.Threading.Dispatcher}, System.Delegate method, object args, int numArgs, System.Delegate catchHandler = null) + 0x3a bytes
WindowsBase.dll!System.Windows.Threading.Dispatcher.LegacyInvokeImpl(System.Windows.Threading.DispatcherPriority priority, System.TimeSpan timeout, System.Delegate method, object args, int numArgs) + 0x10e bytes
WindowsBase.dll!MS.Win32.HwndSubclass.SubclassWndProc(System.IntPtr hwnd = 1383320, int msg = 49594, System.IntPtr wParam = 0, System.IntPtr lParam = 0) + 0xf1 bytes
RandScullard commented
I ran into exactly the same crash. It occurred when I split the editor window. I would love to see this issue fixed!