z0ph/aws-security-toolbox

Nitpick: Use Releases and curl instead of git clone

zbruhnke opened this issue · 1 comments

RUN git clone https://github.com/duo-labs/cloudmapper.git /opt/secops/cloudmapper && \

Just adding this hear as a suggestion mostly AFAICT there is no reason you need git installed here other than the fact that you're cloning entire repos to install them.

However Github has a "release" feature and all the repos you're downloading utilize them. This would allow you to save installing git, just do this with curl and have a lot less work to do installing and building this image.

I also think it would make it cleaner especially because Github makes it easy to package releases for specific OS's so you could only download a .deb file if they are to make one available at some point.

Overall kudos on putting something together and trying to be useful to the community.

z0ph commented

Thanks for your useful feedback, will add this in the next release. Seems legit :)