API consistency
Closed this issue · 1 comments
fieldOfView commented
Since the pyre update, on_peer_enter
, on_peer_exit
, on_peer_join
, on_peer_leave
, on_peer_whisper
and on_peer_shout
all receive the name of the peer that causes the call. on_peer_modified
, on_peer_replied
, on_modified
and the future on_peer_signaled
don't (yet).
Should we add the name argument, for consistency's sake? I'll happily provide a pullrequest.
fieldOfView commented
See pull request for further discussion