new_is_master and new_on_top flags not working properly

[omernaveedxyz]

Issue

Both the new_on_top and new_is_master flags, when set to false, are not working properly. This is based on how the flags perform when using the master layout.

new_is_master, when false, should result in the new window not replacing the current master. This is not the case currently.

new_on_top, when false, should result in the new window being created at the end of the stack. This is also not the case currently.

Workaround

I have modified some of the code in my own fork to work how I believe it should. This is very rough as I do not understand some of the code, but is at least useable.

Config

plugin {
  nstack {
    layout {
      # default placement of the master area
      orientation = left

      # whether a newly open window should be on the top of the stack
      new_on_top = false

      # whether a newly open window should replace the master or join the slaves.
      new_is_master = false

      # whether to apply gaps when there is only one window on a workspace, aka. smart gaps.
      no_gaps_when_only = true

      # (0.0 - 1.0) the scale of the special workspace windows
      special_scale_factor = 0.8

      # inherit fullscreen status when cycling/swapping to another window
      inherit_fullscreen = true

      # the number of total stacks, including the master
      stacks = 2

      # when there is a single window on the screen it is centered instead of taking up
      # the entire monitor
      center_single_master = 0

      # (0.0 - 1.0) master split factor, the ratio of master split
      # if this is set to 0 the master is the same size as the stacks
      mfact = 0
    }
  }
}