zalando-stups/fullstop

Deal with more than 2000 violations properly

rwitzel opened this issue · 3 comments

Current behaviour:

fullstop --limit 5000 returns only 2000 entries if there are more than 3000 entries. And there is no information that are is internal limit of 2000.

Expected behaviour (variant A):

fullstop --limit 5000 returns up to 5000 entries if there are more than 3000 entries.

Expected behaviour (variant B):

fullstop --limit 5000 returns only 2000 entries if there are more than 3000 entries but informs about the maximum of 2000. fullstop --help informs about the limit as well.

Hint: https://github.com/spring-projects/spring-data-commons/search?utf8=%E2%9C%93&q=2000+in%3Afile+language%3Ajava&type=Code

👍 on this issue

Maybe another option is to perform multiple requests on the client side (fullstop-cli) if the limit and actual size are bigger than 2000.

@rwitzel I will close this issue here, as it is quite old. Feel free to file an issue for the fullstop-cli (variant B).