zalando-stups/fullstop

Should violations reappear after being resolved?

sebastianpoeplau opened this issue · 0 comments

Expected behavior

Consider the following case: Someone spawns an RDS instance and accidentally exposes it publicly. We generate a violation, they fix the configuration and resolve the violation. A few months later, someone changes the same instance's configuration, exposing it once more. Then users would expect another violation of the same type to be generated. However, fullstop currently doesn't trigger if there is already a violation for that instance, even if it is a resolved one.

Step needed

  • Evaluate for all violation types whether it makes sense to trigger multiple violations of the same type for the same set of primary keys (such as RDS instance ID).
  • Implement any changes deemed necessary.
  • Possibly inform users.

Dependencies

None.