zalando-stups/skrop

Stripping Metadata

axyz opened this issue · 4 comments

axyz commented

currently image.Process will not strip image metadata.
We could either default to strip it here

func applyDefaults(o *bimg.Options) *bimg.Options {
in order to have a smaller default output

or we can provide a filter to add the required option.

it's also possible to define a global, cmd option for stripping/not-stripping, and create a filter that only overrides this behavior, e.g. stripMeta("true")

this way it is possible to better support different use cases. What do you think, does this make sense?

axyz commented

yeah I think the global option would be nice as most likely you want to strip all the configs and don't want to repeat it everywhere. And being an additional option will not break for backwards compatibility

agree 👍

Fixed by #93