Failing Ingress path after updating to latest Skipper version

Describe the bug

Currently we're trying to update from version v0.13.90 to latest v0.18.51 and we did updated our RBAC as well for ingress.

After updating to latest version in logs we noticed the error's

[APP]time="2023-11-22T13:25:33Z" level=info msg="route settings received"
[APP]time="2023-11-22T13:25:33Z" level=info msg="route settings applied"
[APP]time="2023-11-22T13:25:33Z" level=error msg="* or : in middle of path component .*)?$"
[APP]time="2023-11-22T13:25:33Z" level=error msg="* or : in middle of path component .*)?$/**"
[APP]time="2023-11-22T13:25:33Z" level=error msg="* or : in middle of path component .*)?$/"

To Reproduce
Am using Kubernetes, in Ingress definition we use pathType: Prefix and skipper uses PathSubtree predicate.

My example ingress look like this:

apiVersion: networking.k8s.io/v1  
kind: Ingress  
metadata:  
  namespace: default  
  name: test-ingresss
spec:  
  rules:  
  - host: example.com
    http:  
      paths:  
      - path: "/(testpath)(/.*)?$"
         pathType: Prefix

and we do have other regex example /(hello/testpaths/anotherpath)(/.*)?$ So we're started getting this error * or : in middle of path component .*)?$ from here

skipper/pathmux/tree.go

Line 120 in f16758f

return nil, fmt.Errorf("* or : in middle of path component %s", path)

Expected behavior

No error's about path

Observed behavior


[APP]time="2023-11-22T13:25:33Z" level=info msg="route settings received"
[APP]time="2023-11-22T13:25:33Z" level=info msg="route settings applied"
[APP]time="2023-11-22T13:25:33Z" level=error msg="* or : in middle of path component .*)?$"
[APP]time="2023-11-22T13:25:33Z" level=error msg="* or : in middle of path component .*)?$/**"
[APP]time="2023-11-22T13:25:33Z" level=error msg="* or : in middle of path component .*)?$/"

@janavenkat PathSubtree does not support regular expressions.

thank you for the fast reply. May be I mis-understood.

But same config is working in v0.13.90

@janavenkat v0.13.90 is so old that it had no knowledge about ingress version 1, so v1beta1 applied that had no pathType and therefore always PathRegexp() was used. From the ingress v1 spec I also do not see that it supports regular expressions for Exact and Prefix pathTypes, so I think that's fine.

I hope you read all v0.N.0 release notes, the following might be interesting:

@szuecs thanks for the explanation. I did read but not fully aware it's using PathRegexp in v13.

So to use PathRegexp what should I do now?

https://github.com/zalando/skipper/blob/f16758f090bc207fb05b88d0a3ff7c26eaa7c999/docs/kubernetes/ingress-usage.md#plain-regular-expression
Add annotation like this zalando.org/skipper-ingress-path-mode: path-regexp

Yes that would work, or change pathType: ImplementationSpecific, I think this should also fix it.

make sense thank you for the fast help appreciate it.

I will test and close the issue

What is the expected match behaviour?
Try maybe just

  - path: "/testpath"
    pathType: Prefix

What is the expected match behaviour? Try maybe just
  - path: "/testpath"
    pathType: Prefix

no am using regex in the path

@szuecs I'm still getting the same error even after setting it to ImplementationSpecific.

But If I set the annotation zalando.org/skipper-ingress-path-mode: path-regexp then I don't get the error anymore.

Yeah the pathType setting is global and can be changed by flag to skipper or options if you built your own proxy. I am not sure out of my head what the default is. If you don't find it but want to change it global, let me know I can check it later.
The annotation will override all global decisions.

After setting the annotation am not able to reach the domain anymore. ingress-path annotaiton is already set to deprecated.

Yeah the pathType setting is global and can be changed by flag to skipper or options if you built your own proxy. I am not sure out of my head what the default is. If you don't find it but want to change it global, let me know I can check it later. The annotation will override all global decisions.

In docs says, if we set pathType: ImplementationSpecific is the default Kubernetes ingress mode. But it's still errors in skipper.

Not sure why we have to build own proxy. For example: nginx controller handles regex path with ImplementationSpecific

Yeah the pathType setting is global and can be changed by flag to skipper or options if you built your own proxy. I am not sure out of my head what the default is. If you don't find it but want to change it global, let me know I can check it later. The annotation will override all global decisions.

You mean about this flag to skipper right?

kubernetes.io/ingress.class: skipper

No I mean the flag -kubernetes-path-mode as args to skipper binary.

I also don't mean that you have to write your own proxy. There are many people using it as library and many that use the binary as it is.

No I mean the flag -kubernetes-path-mode as args to skipper binary.

I also don't mean that you have to write your own proxy. There are many people using it as library and many that use the binary as it is.

Thank you. Currently it's -kubernetes-path-mode=path-prefix

Also noticed if I set the annotation to annotations: kubernetes.io/ingress.class: skipper and then error is gone 🤷‍♂️

No I mean the flag -kubernetes-path-mode as args to skipper binary.
I also don't mean that you have to write your own proxy. There are many people using it as library and many that use the binary as it is.

Thank you. Currently it's -kubernetes-path-mode=path-prefix

That's PathSubtree predicate as implementation.

Also noticed if I set the annotation to annotations: kubernetes.io/ingress.class: skipper and then error is gone 🤷‍♂️

Maybe it ignores the ingress that you mention, but this won't fix the implementation fro skipper point of view.

Thanks for the help @szuecs it worked.

We switched to latest version of skipper with the change of pathtype.