Consider switching 'httpclient' dependency

Question

Consider switching 'httpclient' dependency

jbellmann opened this issue 8 years ago · 6 comments

jbellmann commented 8 years ago

... to be a compile/runtime dependency.

To avoid issues like #60 .

Another point would be to maybe force the user to have latest to be up to date. To hopefully avoid issues like #52 .

Answer 1 · 2017-02-21T11:52:12.000Z

@harti2006 ??

Answer 2 · 2017-02-21T12:21:28.000Z

but what about #14 ?
This PR /feature would be completely obsolete then.

Answer 3 · 2017-02-21T13:22:29.000Z

No, not true, imo. The #14 brings in all the abstractions needed to drop the default-implementation (provided by us) and plug in a different one (maybe async, as mentioned in #14). That's fine.

Here we talk about 'shipping' the dependency (library) needed by our 'default-implementation'. Users are still able to completely put in their own 'HttpProvider' implementation (maybe with 'httpclient-async' or 'ok-http').
But we could improve the 'out-of-the-box' experience for 'tokens' with default-implementation working without putting the user in responsibility to care about adding dependencies we already know about.
Excluding this library from users project should be simple for an developer.

Answer 4 · 2017-02-21T13:34:42.000Z

Ok, I agree. So if someone does not want to use our implementation, they can simply exclude Apache httpclient from their dependencies configuration 👍
Then it makes sense to add it as compile time dependency.

Answer 5 · 2017-02-21T13:44:13.000Z

Nice, will create the PR for this and let you know.

Answer 6 · 2017-02-21T21:26:48.000Z

Fixed with 0.10.0