zalando/zappr

Open Task check misses checked tasks

BGehrels opened this issue · 3 comments

BGehrels commented

Given an existing PR and
given you've activated the zappr/pr/tasks check
when you've edited it's first comment to include a task list with one element
then zappr correctly blocks the PR.

Given the above,
when you click on the checkbox for the task
then zappr some times still blocks the pr saying "zappr/pr/tasks — PR has 1 open tasks."

BGehrels commented

The last webhook transmission contains the checked task list entry in $.issue.body:

"The current code ANONYMIZED then).\r\n\r\n- [x] Implement ANONYMIZED alarms (and ANONYMIZED data) are ANONYMIZED."

harti2006 commented

I can confirm the bug. It is definitely related to the current issue with GitHub Enterprise sending the wrong pull request body with the webhook.

However in this case it is also suspicious that the "body" attribute is below "issue" instead of "pull_request".

harti2006 commented

This issue is fixed now, since Github sends the correct webhook payload again.