Support non-JSON values

Question

Support non-JSON values

Closed this issue 9 years ago · 7 comments

The extension serializes state with jsan, losing values like undefined or function.

The way to fix this is to use node-stringify / eval, instead of jsan.stringify / jsan.parse.
(there is probably a better option than eval, I'm not sure) :)

Answer 1 · 2016-02-23T12:21:56.000Z

I guess node-stringify will not support circular references. Before jsan we've also used circular-json and json-stringify-safe, but jsan seems to be faster than competitors.

I think we better add that in jsan as @kolodny uses our extension and will accept a PR (?)

Answer 2 · 2016-02-23T15:53:01.000Z

Oh, that seems better, indeed.

Answer 3 · 2016-02-24T21:57:34.000Z

@zalmoxisus @alexkuz I wrote a helper function to do this, let me know if it solves your use case

kolodny/jsan#1 (comment)

Answer 4 · 2016-03-01T09:50:42.000Z

@alexkuz, you can try it in 1.0.0.8. Thanks a lot, @kolodny!

Also added redux-devtools-inspector monitor in #64.

Answer 5 · 2016-03-01T17:44:06.000Z

@zalmoxisus thank you!

Answer 6 · 2016-03-01T18:26:29.000Z

@alexkuz, unfortunately, I've temporally reverted it due to #67.

Answer 7 · 2016-03-03T18:45:16.000Z

Should work well now. Thanks to everybody for working on this!