zaninime/sbt-derivation

`passthru` attribute is not passed through

avdv opened this issue · 1 comments

avdv commented

I am trying to migrate to version 2.

In my project I am using

passthru = { exePath = "/bin/scalals"; }

and it was working fine. After upgrading to sbt.lib.mkSbtDerivation it is no longer working.

Looking into https://github.com/zaninime/sbt-derivation/blob/master/lib/sbt-derivation.nix I can see that the passthru argument is never actually used, and the passthru attribute of the args is always overriden to just { dependencies = dependencies; } here:

sbt-derivation/lib/sbt-derivation.nix

Line 64 in fe0044d

passthru.dependencies = dependencies;

zaninime commented

Thanks for the report! Should be good to go now.