zapatacomputing/benchq

Example 3 includes architecture_model as a parameter for azure_estimator

Closed this issue · 0 comments

Describe the bug

examples/ex_3_packages_comparison.py has the following code for calling the Azure estimator:

    with measure_time() as t_info:
        azure_resource_estimates = azure_estimator(
            algorithm,
            architecture_model=architecture_model,
        )

However, azure_estimator takes hw_model:

def azure_estimator(
    algorithm: AlgorithmImplementation,
    hw_model: Optional[BasicArchitectureModel] = None,
    use_full_circuit: bool = True,
) -> AzureResourceInfo:

At the very least, the example file should be changed to use hw_model. However, since currently hw_model is not working properly and throws a warning to the user, it may be best to not pass in the architecture_model object at this time.

How to Reproduce

Run the ex_3_packages_comparison.py file.

Actual behavior

Currently, the following error is seen:
TypeError: azure_estimator() got an unexpected keyword argument 'architecture_model'

Environment (please complete the following information):**

  • latest version of BenchQ
  • Python 3.11.5