v44 shows incorrect rewards, reward types and completion (blue skull instead of white) for several rares in the Emerald Dream

[hollo6]

ADDON VERSION: v44

Describe the bug
Some rares in the Emerald Dream show incorrect rewards or reward types on their tooltips or icon completion state.
Didn't have time to take a screenshot of Mosa Umbramane, it was showing Owlbear's Decisive Strike being a Recipe on a Tailor/Enchanter character.
See screenshots for other issues I've found.

Screenshots
this item should be a Recipe and only shown for Scribes (my character is not one), and it doesn't drop from this rare:

still blue even though all rewards are known (works correctly in v43):

[hollo6]

Found two more, these already exist in v43:

[Dathwada]

Which class do you play?
Are all screenshots from your Tailor/Enchanter character ?

[hollo6]

First 2 screenshots (Bloodstripe Great Ray, Splinterlimb) are from Druid (Herb/Alchemy), the others from Warlock (Tailor/Enchanter).
But I have every class and every profession I can test with if that helps.

[Dathwada]

Please try to disable and re-enable the rares and see if this fixes the rares are still blue for now.

• Fixed Mosa Umbramane loot.
• Bloodstripe Great Ray drops no recipe (see wowhead)
  • I'll also remove Hairy Chin

Screenshots from my druid with alchemy and enchanting

[hollo6]

I just updated back to v44 to test if re-enabling the rares fixes this issue but it seems to work after login/reload. I have noticed this on both characters after some time of normal gameplay, so there must be some trigger for this behavior.

[hollo6]

Now the still blue problem happened after logging in and doing nothing special. Re-enabling rares fixed it but only temporarily.

[Dathwada]

It looks like only rares that have recipes as a reward are affected.

[Ioney]

@Dathwada can you try to add

function Recipe:IsObtainable() return ns.PlayerHasProfession(self.profession) end

to line 450 in core/rewards.lua

maybe this helps?

[hollo6]

function Recipe:IsObtainable() return ns.PlayerHasProfession(self.profession) end

to line 450 in core/rewards.lua

maybe this helps?

I don't think that would help because the affected characters have that profession and learned those recipes.

[Dathwada]

@Dathwada can you try to add

function Recipe:IsObtainable() return ns.PlayerHasProfession(self.profession) end

to line 450 in core/rewards.lua

maybe this helps?

Doesn't work.

The issue is that Recipe:IsObtained() returns false at login.

[Dathwada]

I checked this on the TWW beta and it looks like this is fixed and we can determine at login if a recipe is obtained.