zarino/backchat

Users who join after me are incorrectly added to notification keywords

Closed this issue · 0 comments

The channel:joined event handler incorrectly adds each new user’s nick to the keywords array. This means each user who joins after me is added to the array.

this.keywords.push(e.user);

I think the original intent of this line was to add my nick to the keywords array. Surely there must be a better way for the client to figure out what the current nick is and add it? Maybe the server could just add it to serverSettings.keywords before it's passed to the client?