zarocknz/javascript-winwheel

SpinOngoing defaults not applied as expected

Closed this issue · 1 comments

While looking in to a query on the SpinOngoing animation I discovered that the defaults as stated in the documentation are not being applied.

Namely the repeat and easing expected are -1 and Linear.EaseNone but because in the constructor of the winwheel 0 is specified for the repeat and power3.easeOut is defined for the easing these are not null so the defaults for the SpinOngoing type of animation are not applied.

Solution is probably to ensure that these are null in the constructor and are only set by a check of the animation type to the default if not specified in the parameters.

Note animation class reference does say what the defaults are but this needs to change to list the defaults for each type of animation since some properties can be different depending on the animation.