zarplata/concourse-git-bitbucket-pr-resource

branch option may not be working as intented

RubenJG opened this issue · 5 comments

RubenJG commented

When I read about the branch option, I thought it would allow me to specify to only listen to PRs created against a specific target branch but when I started testing I noticed that this option only works to specify a source branch.

As an example, if I have a branch feature/x and I create a PR feature/x --> develop. If I specify develop in the branch option, it never picks up the PR. If I specify feature/x, it does pick it up.

Not sure if this is intended functionality. If it is, could a target_branch be added as well?

danilopopeye commented

As an example, if I have a branch feature/x and I create a PR feature/x --> develop.
If I specify develop in the branch option, it never picks up the PR.

@RubenJG are you using the Server or Cloud version? Just tested against a Server instance and it worker as it should.

RubenJG commented

I was using the Cloud version @danilopopeye

danilopopeye commented

I was using the Cloud version @danilopopeye

hummm, I don't have a Cloud account to test it. 😞
Can you sanitise a payload JSON and post it here, @RubenJG ?

mymasse commented

I ran into this issue and specifying direction: incoming fixed the issue.

direction: Optional. the direction relative to the specified repository, either incoming (destination, e.g. to master) or outgoing (source, e.g. from feature)

RubenJG commented

I no longer have access to the code @danilopopeye 🤔 but what you say @mymasse makes sense. I think it would've helped me. Probably #47 fixed this issue 👍