Build script doesn’t test on COOP report

Question

Build script doesn’t test on COOP report

Closed this issue 4 years ago · 15 comments

sagelga commented 5 years ago

The script only tests on project report.

Ways to fix:

add the coop report test that is independent to project report

Answer 1 · 2020-06-25T06:32:32.000Z

I can’t tag @kavinvin but I can tag @DobaKung

Answer 2 · 2020-09-24T16:25:54.000Z

Let's settle with thesis thing first. This can be solved later in the main repo.

Answer 3 · 2021-03-04T06:07:41.000Z

This issue is so stale @DobaKung

Answer 4 · 2021-03-04T06:42:47.000Z

Can we merge it first? The pull request is already big enough. And coop folder is kind of independent from the project one. The one who's still using this can solve it too if they want.

Answer 5 · 2021-03-04T07:09:33.000Z

How much efforts you need to fix the issue? I still don’t understand what’s keeping this PR on hold. And for the “should we merge”, i felt like we should merge on things that works fine, and open another PR on things that are broken.

…

On 4 Mar 2021 13:43 +0700, Kavin Ruengprateepsang ***@***.***>, wrote: Can we merge it first? The pull request is already big enough. And coop folder is kind of independent from the project one. The one who's still using this can solve it too if they want. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

Answer 6 · 2021-03-06T03:29:38.000Z

@sagelga I guess it will requires not too much effort if I don't need to fix the error things when adding test to COOP. And it does have errors in the COOP file itself. Maybe because our build process is different? I'll try to fix it soon.

Answer 7 · 2021-03-06T03:36:54.000Z

Almost all of the Coop work is inherited by P’ Chin. You might need his help tho. Else you can figured this out, that’ll be great.

…

On 6 Mar 2021 10:29 +0700, Kavin Ruengprateepsang ***@***.***>, wrote: @sagelga I guess it will requires not too much effort if I don't need to fix the error things when adding test to COOP. And it does have errors in the build process itself. Maybe because our build process is different? I'll try to fix it soon. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

Answer 8 · 2021-03-06T03:50:13.000Z

@sagelga I fixed the error. Only need to add Angsana New fonts.

But, "Coop" uses Angsana and "Project" uses Kinnari. Should we change them to be the same? I guess we have to uses Angsana anyway when submitting the real report. Any thoughts? @DobaKung

Answer 9 · 2021-03-06T03:54:58.000Z

I remembered that Kinnari is for replacing “missing fonts” in OS that is not Windows. I still don’t know that they are ok with Kinnari or not, but I felt like it’s a yes because Doba use it as a “resemblance” of Angsana New and no one will noticed it. Could you make it to use Kinnari as an **fallback font** for non-Windows? @kavinvin

…

On 6 Mar 2021 10:50 +0700, Kavin Ruengprateepsang ***@***.***>, wrote: @sagelga I fixed the error. Only need to add Angsana New fonts. But, "Coop" uses Angsana and "Project" uses Kinnari. Should we change them to be the same? I guess we have to uses Angsana anyway when submitting the real report. Any thoughts? @DobaKung — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

Answer 10 · 2021-03-06T04:00:51.000Z

@sagelga I think Angsana New is also fine for non-Windows? (If we ignore the copyright thing)

And I don't think they looks similar. It looks very different in bold title. If I remember it correctly, @DobaKung still needs to change his to Angsana when submitting the final file.

Answer 11 · 2021-03-06T04:17:11.000Z

Yes, I switched to Angsana in the final file because Kinnari's bold weight is not bold enough. Will update the class to use Angsana New.

Answer 12 · 2021-03-06T04:19:55.000Z

Aaaa. Generic Doba thing.

…

On 6 Mar 2021 11:17 +0700, Nathan Yiangsupapaanontr ***@***.***>, wrote: Yes, I switched to Angsana in the final file because Kinnari's bold weight is not bold enough. Will update the class to use Angsana New. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

Answer 13 · 2021-03-06T04:29:43.000Z

I guess this issue is also related to #2.

Remind someone to also close #2 when this issue is fixed.

Answer 14 · 2021-03-17T10:56:09.000Z

Should we just merge this repo to DSMLR and continue opening the PR?
Hoping other ppl send commit and fix this things up.

If it still in this repo, no one will knows this fork existed and did not get any benefits by our work

Answer 15 · 2021-03-21T05:34:25.000Z

This issue is fixed with #25