zattoo/reviewers

Check if a reviewers ia already requested before re-assigning him

Opened this issue · 2 comments

As discussed in https://github.com/zattoo/web/pull/3626 we don't want the automation to automatically ask reviewers to re-check pull-request, but rather we want this option to be in our hands.

So we shall check if a reviewer is already assigned to a pull-request before requesting his review by getting requested reviewers

@gotbahn OK, I was wrong again, requested-reviewers is giving back only reviewers who still didn't give a review, so we will be at the same place as before

Once a user who was requested to give a review gave a review, he is no longer on the list of requested reviewers :/

Another option would be to collect all users who gave a review on a pull request and omit them from the request. that can work

@nitzanashi interesting how GitHub build reviewer list, they use the same API, so definitely should be possible. Let's keep it like that for some time and see if someone except me complains.