zauberlabs/gnip4j

Matching rules doesn't have the ID field

Closed this issue · 3 comments

eblanco90 commented

Hello,

In the new GNIP 2.0, the field matching_rules now has the fields "tag" and "id". However, this change is not implemented in the class "MatchingRules" since there is only "tag" and "value" (old version).

We should add a field in this class called "id" (and maintain the "value" one for compatibility).

Thanks.

jcodagnone commented

You are right. Fixed!

eblanco90 commented

Hello, I think this should be too in the class "MatchingRules", that's the class we use to get the ID. Thanks.

jcodagnone commented

Right! 299a22b

  • 👍1