zazuko/xrm

Content proposals for LSP

Closed this issue · 6 comments

mchlrch commented

Move the existing xrm proposal logic to the generic IdeContentProposalProvider.

(Follow-up of #92 (comment))

nnamtug commented

work in progress.
fyi: works on branch in inner eclipse. next steps:

  • mvn clean verify (main project)
  • editor-test eclipse
  • test in vs-code
nnamtug commented

How to debug VS-Code having the language server in running debug mode within eclipse:

  1. start server within eclipse using RunPlainTcpServer.java
  2. stage vscode, copy expressive-rdf-mapper-vscode/vscode-extension-self-contained/src/extension-***.ts.txt to extension.ts
  3. run vscode: ./gradlew startcode

optionally: link tcpmon.jar by tunneling ports 4388-->4389 (and stage vscode accordingly). The good old tcpmon.jar had to be modified in order to build it, find it in my fork for tcpmon.jar

nnamtug commented

In the debugging setup above, IdeContentProposalProvider may not be replaced, since the default languages always will be registered when launching from eclipse.
Next step: Find out whether IdeContentProposalProvider will properly be replaced in the standalone-server backing vscode by RdfMappingIdeProposalProvider

  • if yes: let's talk
  • if no: we are doomed - let's talk
mchlrch commented

I was able to replicate the setup for debugging as described above with running the RunPlainTcpServer in Eclipse.

I saw that the createProposals hook didn't get called, so I tried with adding the binding for RdfMappingIdeProposalProvider.

After this change, I can see that the createProposals hook in the RdfMappingIdeProposalProvider does get called in the debugging setup

  • 👍1
nnamtug commented

rdf-mapping-dsl: pullrequest #117 is available

expressive-rdf-mapping: what do we need to do there? how are the changes to be verified? which flavors are affected by this, like vscode standalone, theia, gitpot, others? so I did not create a pullrequest yet

mchlrch commented

I haven't verified the proposals in the vscode standalone build systematically yet. I plan to do that in the next days.

PR merged. Closing this.