unic-langid 0.5.3 breaks semver

[distransient]

Moving types from the namespaces into the root is a semver breakage.

Please yank!

[zbraniecki]

thanks! yanking!

[zbraniecki]

I think I yanked all the broken revisions. I published them as 0.6.

Thank you again!

[Ratysz]

There seems to have been another breakage earlier, somewhere. Recent Amethyst revisions prior to amethyst/amethyst#1959 fail to compile with

Compiling amethyst_locale v0.7.0 (E:\Projects\amethyst\amethyst_locale)
error[E0277]: the trait bound `unic_langid_impl::LanguageIdentifier: std::convert::From<unic_langid_impl::LanguageIdentifier>` is not satisfied
  --> amethyst_locale\src\lib.rs:37:26
   |
37 |         let mut bundle = FluentBundle::new(&[lang_en]);
   |                          ^^^^^^^^^^^^^^^^^ the trait `std::convert::From<unic_langid_impl::LanguageIdentifier>` is not implemented for `unic_langid_impl::LanguageIdentifier`
   |
   = note: required because of the requirements on the impl of `std::convert::Into<unic_langid_impl::LanguageIdentifier>` for `unic_langid_impl::LanguageIdentifier`
   = note: required by `fluent_bundle::bundle::FluentBundle::<R>::new`

error: aborting due to previous error

[zbraniecki]

@Ratysz - I hope that yanking fixes that. Does it not?

[distransient]

Thanks for the quick response!

[Ratysz]

This log is from trying it like two minutes ago, after cargo clean and cargo update, so I think yanking 0.5.3 didn't fix this (it did fix revisions after the linked PR, though).

[zbraniecki]

I tested on local master:

cd amethyst_locale
cargo clean
cargo update
cargo build
cargo test

and it works. Not sure how to test it further?

[Ratysz]

The problem is with earlier revisions. amethyst_locale 0.7.1 compiles just fine, thanks to your swift action; anethyst_locale 0.7.0 (fresh, of course) doesn't compile anymore, failing with the error I pasted. (This crops up while I'm trying to compare different revisions of Amethyst to find out if there was a regression in amethyst_tiles; I might be doing it wrong, though.)

[zbraniecki]

ah, hmm, I think it must be some misalignment between fluent-locale and fluent-bundle. I'll update both to use unic-langid 0.6 soon.

[zbraniecki]

ok, yanked fluent-bundle and fluent 0.7.2. It should make both use 0.7.1 which uses 0.4

[zbraniecki]

ugh, but that broke master :(

[Ratysz]

Fixed the revisions I'm interested in, though; thank you!

EDIT: Oh, I see what you mean. I am so sorry.

[zbraniecki]

no worries! updating all the crates :)

[zbraniecki]

ok got all crates updated - unic-langid to 0.6, fluent-locale to 0.10 and fluent to 0.8.

We may need to yank amethyst_locale 0.7.1 and push 0.7.2 updated to those revisions!