Using `str` instead of `Text`
yourhonor1996 opened this issue · 2 comments
yourhonor1996 commented
Hi! Thanks so much for your efforts, well done, excited for more!
One thought...
you have used the Text typing instead of str in your functions. Take a look at this link.
I think it's better to use str instead of Text unless we want backward compatibility for python2 code.
zedr commented
Thanks for commenting on this. I think you're right in jettisoning PY2 compatibility. Would you like to submit a pull request with the changes?
yourhonor1996 commented
sure, will make some time to it.