zeebe-io/zeebe-modeler

Investigate why `npm run release` is not enough to trigger distro job on CI

barmac opened this issue · 6 comments

barmac commented

What should we do?

Investigate why npm run release is not enough to trigger distro job on CI. The possible reason is that we do not have a tag commit as creating this manually fixes the problem.

Why should we do it?

When I run npm run release for Zeebe Modeler 0.9.1 release, lerna created just an ordinary git tag instead of an annotated one. This caused Travis CI to skip the commit in the distro stage. I had to replace tag manually. @pinussilvestrus confirmed that he experienced the same issue.

nikku commented

What is an ordinary vs. an annotated tag? 🤔

barmac commented

git tag v0.9.1 (that's what probably lerna run with npm run release, outcome) v. git tag -a v0.9.1 (outcome). In the second case you get a commit which contains only the commit message plus reference to tag.

I guess we could just fix it on CI. 🤷

nikku commented

I do not see the relevant difference.

In both cases, CI will pick up the new tag and build it. Right?

pinussilvestrus commented

Nope, that's the thing here. In the first scenario, CI does not trigger the distro builds. Maciej had to annotate the tag manually to properly work

  • 👍1
barmac commented

OK let's clarify this issue. The problem was that I had to manually create a tag commit to have the release picked up by CI.

barmac commented

I updated the issue description.