ensure encoding works with pointer receivers well

Question

ensure encoding works with pointer receivers well

zeebo opened this issue 7 years ago · 4 comments

we need to be careful around our usage of indirect and checking if the value implements some interface during encoding. i suspect there are some bugs.

Answer 1 · 2017-11-03T20:12:19.000Z

I suppose this also applies to the original RawMessage "cast", @zeebo?

Answer 2 · 2017-11-03T20:15:51.000Z

yeah i think so. i think we just need to rethink the top of encodeValue and decodeValue.

specifically, maybe we have to extend indirect to check for interfaces at every level and return whichever as early as possible...

Answer 3 · 2017-11-03T20:17:39.000Z

Sounds like a good idea indeed. I'll do some research and think about it when I get to it.

Answer 4 · 2017-11-04T03:54:05.000Z

@zeebo my solution can be found as PR #29.