zeehio/facetscales

Some questions to answer

zeehio opened this issue · 1 comments

This is the feedback @clauswilke gave me at tidyverse/ggplot2#2747

I have a number of questions:

  1. Should this be implemented for facet_wrap() as well?

Tracked on #7

  1. What happens with coord_fixed()?

Error: coord_fixed doesn't support free scales

  1. What happens when people try to set individual titles for the different scales?

Tracked on #4

  1. When I have a grid of plots with multiple columns and rows, can I set a different scale for each plot?

Not yet addressed

  1. What happens when facets are renamed via a labeller function?

Facets are renamed on the plot. No apparent issue here.

  1. What happens when people define a scale outside of the facet_grid() call, and does it matter whether it's called before or after facet_grid()?

That scale should be used if it is not overriden by facet_grid_sc. This needs to be checked and tested.

This may be a case where implementing this first in a package to gain some experience with this feature and explore the best interface may be a good idea.

I plan to address and refine the facetscales API (as time permits) and then submit a pull request with those issues (and other issues that will appear) addressed. Discussion is welcome!

I don't think maintaining this project is a good idea for reasons outlined in the readme. Therefore I am closing all issues and pull requests and archiving the project.