zen-audio-player/zen-audio-player.github.io

Video IDs containing - don't parse correctly

shakeelmohamed opened this issue · 5 comments

shakeelmohamed commented

For video URLs like https://www.youtube.com/watch?v=UAWcs5H-qgQ only UAWcs5H is parsed out. The bug is likely somewhere in js/zap-common.js.

Also:

  • https://www.youtube.com/watch?v=i-b4wn2TPRI only i is parsed
cipher1729 commented

Both the above URLs seem to work just fine. Could you please elaborate on how to reproduce this issue?

cipher1729 commented

I've found a fix for it. I'll create a pull request

rjstires commented

This would inherently be addressed by PR #110

  • 👍2
rjstires commented

Will be closed by #226