Netron not support
valuefish-buaa opened this issue · 7 comments
I can't change the theme of Netron through Gray. Even though through the command line defaults write -app Netron NSRequiresAquaSystemAppearance -bool Yes
, it can only change the title bar to bright color like below:
Afaik Gray excludes Electron apps.
Seems similar to #66.
We could remove this check to allow Electron apps now that they seem to support this.
Hey @valuefish-buaa, please download the latest version of Gray, it should support Netron now that Electron apps are allowed back in the list of applications. Cheers!
Thanks for your reply, @zenangst . I have download version 0.9.10 of Gray. The background color of Netron is still dark though I set bright theme with Gray. Like below:
When I set bright theme through Apple System Preferences, the Netron show like below:
Interesting, I’m gonna try and download the app to reproduce the issue. I’ll keep you posted!
@valuefish-buaa I downloaded the app and got the same result as you did. So I dug into the source code of Netron and found how they implemented support for dark mode on Mojave.
https://github.com/lutzroeder/netron/blob/master/src/app.js#L576
As you can see, they rely on what setting you have in system preferences rather than respecting the applications own preference setting. I'm afraid there is nothing that Gray can do to fix this issue.
Understood, thanks very much!