zenangst/Spots

Refactor `render()` into `view`.

zenangst opened this issue · 3 comments

zenangst commented

I always found it weird and odd that render() is a function that returns the view for the Spotable object. I think it would be nicer and more natural if the Spotable object had a computed property called view.

This would very much be a breaking change but I well worth one in my opinion.
Maybe this could be something that we go for in 6.0.0.
We do have some other breaking changes that we would like to implement as well (see the issue about the protocols), and the naming convention of delegate methods.

onmyway133 commented

I found it weird too. Especially when it is like this

spot.render().removeFromSuperview()
zenangst commented

render() is more an action that you perform on a view. I think we added that on Spots inception and never felt the need to change it.

vadymmarkov commented

Yes, I think we should do it.