Improve naming of `itemsPerRow`

Question

Improve naming of `itemsPerRow`

zenangst opened this issue 7 years ago · 12 comments

I find that itemsPerRow on Layout is a bit misleading, I think we can come up with a better name for this property.

Answer 1 · 2017-05-22T07:35:35.000Z

How about preferredNumberOfRows ?

Answer 2 · 2017-05-22T08:05:16.000Z

@onmyway133 yeah I kinda like that, but I wouldn't add preferred as a prefix. If you set that, it will arrange the items based on the items height which would give you a "column" height of 2 even if you only have 1 item.

Answer 3 · 2017-05-22T08:36:47.000Z

@zenangst yeah, inspired by numberOfLines. I have preferred because it will not always be the number of lines we want, if we have too few items. But I 👍 with dropping preferred

Answer 4 · 2017-05-22T11:59:04.000Z

@vadymmarkov @JohnSundell what do you guys think about numberOfLines is that more descriptive than itemsPerRow ?

Answer 5 · 2017-05-22T12:09:32.000Z

@zenangst what's wrong with itemsPerRow? I find it pretty descriptive 🙂

Answer 6 · 2017-05-22T12:12:56.000Z

@JohnSundell I'm just afraid that it might be confused with vertical layouts where everything is per row. If this is what you think you would get by setting that property then it might not be an issue at all:

Answer 7 · 2017-05-22T12:13:41.000Z

yeah, I'm still using my silly example to show of the feature 😁

Answer 8 · 2017-05-22T15:27:50.000Z

What about columns 😄

Answer 9 · 2017-05-23T06:29:32.000Z

But columns are horizontal, what you are setting are the amount of rows per column... I think. This whole thing has gotten med confused ;)

Answer 10 · 2017-05-23T06:30:02.000Z

itemsPerColumn?

Answer 11 · 2017-05-23T07:37:13.000Z

Hm.. columns are vertical, rows are horizontal 🤔

Answer 12 · 2017-05-23T07:47:43.000Z

I edited my previous comment.