zendesk/app_scaffold

from-scratch branch does not include moment in the external js assets

Closed this issue · 5 comments

StephenMP commented

The current webpack.config.js is as follows:

var externalAssets = {
  css: [
    'https://assets.zendesk.com/apps/sdk-assets/css/0/zendesk_garden.css'
  ],
  js: [
    'https://cdn.jsdelivr.net/g/lodash@4.14.0,handlebarsjs@4.0.5,jquery@3.1.0',
    'https://assets.zendesk.com/apps/sdk/2.0/zaf_sdk.js'
  ]
}

It should be:

var externalAssets = {
  css: [
    'https://assets.zendesk.com/apps/sdk-assets/css/0/zendesk_garden.css'
  ],
  js: [
    'https://cdn.jsdelivr.net/g/lodash@4.14.0,handlebarsjs@4.0.5,jquery@3.1.0,momentjs@2.18.1',
    'https://assets.zendesk.com/apps/sdk/2.0/zaf_sdk.js'
  ]
}
danielbreves commented

@StephenMP that was intentional. We didn't think moment was essential for most users, so we left it out, especially considering it's quite a large library. It can be added on a case by case basis. Will close this for now.

StephenMP commented

If it's intentional, then should it be removed from the Webpack config's externals?

externals: { handlebars: 'Handlebars', jquery: 'jQuery', lodash: '_', moment: 'moment', zendesk_app_framework_sdk: 'ZAFClient' },

to

externals: { handlebars: 'Handlebars', jquery: 'jQuery', lodash: '_', zendesk_app_framework_sdk: 'ZAFClient' },

danielbreves commented

Oh yes, good catch!

StephenMP commented

Glad to help :)