zendesk/samson

ActionView::SyntaxErrorInTemplate when viewing Project Webhooks

patrobinson opened this issue · 3 comments

Getting a weird error in production, I'm unable to replicate this locally.
When viewing a Project's Webhooks we get a 500 error:

ActionView::SyntaxErrorInTemplate (Encountered a syntax error while rendering template:
<snip>
app/views/webhooks/index.html.erb:200: syntax error, unexpected keyword_do, expecting keyword_end
app/views/webhooks/index.html.erb:239: syntax error, unexpected keyword_end, expecting end-of-input
app/views/webhooks/index.html.erb:200: syntax error, unexpected keyword_do, expecting keyword_end
app/views/webhooks/index.html.erb:239: syntax error, unexpected keyword_end, expecting end-of-input
app/views/webhooks/index.html.erb:200: syntax error, unexpected keyword_do, expecting keyword_end
app/views/webhooks/index.html.erb:239: syntax error, unexpected keyword_end, expecting end-of-input
app/views/webhooks/index.html.erb:200: syntax error, unexpected keyword_do, expecting keyword_end
app/views/webhooks/index.html.erb:239: syntax error, unexpected keyword_end, expecting end-of-input

Which relates to this line https://github.com/zendesk/samson/blob/master/app/views/webhooks/index.html.erb#L200
Once that line (and it's surrounding block) is removed the error doesn't occur.

I'm thinking it's &.stage_id ... maybe production is running on an old ruby version ?

@grosser interesting, we thought that too and tried to upgrade. I'll make sure it's working.

upgrading to 2.6.3 fixed that issue. Getting a different one now