zendeskgarden/css-components

Disabled menu items don't look disabled

Closed this issue · 3 comments

Hope this is the correct place to raise this...

With the recent Garden updates on the Talk admin, we have this newly styled dropdown menu.

screen shot 2018-02-21 at 1 29 08 pm

It's used to bulk update numbers that you may have selected.
However, if you have not selected any numbers, all the menu items are disabled and have the grey font colour.
It's not very clear that they're unclickable, especially as they seem to be a shade darker than the clickable tab links above.

Perhaps we should be hiding the menu if you haven't selected any numbers, but I still think maybe the colours here should be reviewed for disabled text and items.

Willing to provide more context or contribute code if needed :)

cc: @Austin94

👋 Hi @scott2211 this is definitely the right place to raise this.

I actually noticed this a little while I was helping the Mongooses team, but didn't realize how clickable it looked if ALL items were disabled.

We definitely have a "50 shades of gray" problem with some of our muted states. @allisonacs once we start addressing the new color palette, was that going to also be a chance to review the disabled/active states as well? If so we can look at this when we start bringing things over.

Yes, this is going to be addressed in the color work, and the greys should all get revamped so that you won't run into situations where e.g. the tab color is lighter than the disabled color. 😬

Cool, good to know it's on the list.

Thanks @Austin94, @allisonacs! 👍