zendeskgarden/css-components

input[type=search] doesn't have consistent styling in Safari

Closed this issue · 2 comments

dlee commented

Expectations

screen shot 2018-02-28 at 2 18 06 pm

Reality

screen shot 2018-02-28 at 2 18 31 pm

Steps to Reproduce

Being used via Garden TextInput: https://github.com/zendesk/zendesk_console/blob/production/lotus_react/src/Admin/TicketFields/Landing/index.js#L79-L86

Fine Print
  • Component: <TextInput>
  • Browsers: Safari
dlee commented

screen shot 2018-02-28 at 2 03 01 pm

Slight discrepancies seen in height even from the Garden components website.

@dlee this is definitely something that we should fix just for consistency, but after reading through https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input the [type="search"] attribute doesn't provide any additional accessibility (like number, date, etc.) and only provides the icon.

I would suggest just letting the type default to "text".

The second screenshot you originally posted of the super-small input. How did you get that to occur?