zendeskgarden/react-components

Props being applied to DOM elements.

ffind opened this issue ยท 4 comments

ffind commented

Expectations

I showed up, expecting to have my mind blown.

Reality

Using ToastProvider for Notification component, and there is an issue that toast provider props for some reason being applied to DOM elements.

Screenshot 2023-08-31 at 16 50 07 Screenshot 2023-08-31 at 16 47 55

Steps to Reproduce

  1. Install @zendeskgarden/react-notifications
 <ToastProvider placementProps={placementProps} zIndex={1} limit={3}>{children}</ToastProvider>

Fine Print

  • Component: @zendeskgarden/react-notifications
  • Version: 8.69.9
  • Browsers: all
  • Bundler: vite 4.3.9

Thanks @ffind. We're aware of the issue. The fix will require a styled-components peer dependency bump. So we're holding off until v9. Keep those expectations high ๐Ÿ˜‰

ffind commented

Keeping high! Thank you @jzempel

bkw commented

@jzempel thanks for working on this. Is there an ETA for v9?