Login from zfmodules.com via github doesn't seem to work

Question

Login from zfmodules.com via github doesn't seem to work

heiglandreas opened this issue 10 years ago · 32 comments

Sorry to say, but I encounter an error-message when I try to log in via github.

To reproduce:

Open http://zfmodules.com and click onto the "Github login" link.

I then see the URL http://www.zfmodules.com/user/login/github being called and the server returns

This view is generated by the Error Module
 An error occurred
An error occurred during execution; please try again later.

Or is that just me having misconfigured my machine?

localheinz commented 10 years ago

@GeeH

👍

ins0 commented 10 years ago

HYPE 👍

Answer 1 · 2014-12-23T21:53:29.000Z

It also occurs on any module info page /<vendor>/<modulename>...

Answer 2 · 2014-12-24T12:27:02.000Z

Duplicate of #251.

Answer 3 · 2015-01-13T14:23:51.000Z

I don't know but maybe.. today there is a different problem
If you click to Login return this:

http://modules.zendframework.com/?error=redirect_uri_mismatch&error_description=The+redirect_uri+MUST+match+the+registered+callback+URL+for+this+application.&error_uri=https%3A%2F%2Fdeveloper.github.com%2Fv3%2Foauth%2F%23redirect-uri-mismatch

Answer 4 · 2015-01-24T17:41:12.000Z

it's weird, the github application actually has the right callback url. I'm stumped.

Answer 5 · 2015-01-24T18:49:26.000Z

@GeeH is the redirect url with url path or just the host? so it should be only http://modules.zendframework.com/ as callback

Answer 6 · 2015-01-24T19:06:49.000Z

Which is exactly what it is!

On 24 January 2015 at 19:49:29, Marco Rieger (notifications@github.com) wrote:

@GeeH is the redirect url with url path or just the host? so it should be only http://modules.zendframework.com/ as callback

—
Reply to this email directly or view it on GitHub.

Answer 7 · 2015-01-24T19:08:42.000Z

go home github api you're drunk 🍻 ok don't know what else could be the reason for this strange behavior.

may register a new application and give it a try?

Answer 8 · 2015-01-25T02:01:23.000Z

@GeeH don't know where but the redirect to github looks on production like this https://github.com/login/oauth/authorize?client_id=XXXXXXXXX&redirect_uri=http%3A%2F%2Fzfmodules.com%2Fscn-social-auth%2Fhauth%3Fhauth.done%3DGitHub&response_type=code&scope=user%2C+public_repo%2C+ so the github application configured is not from the github account where u lookup the url or somewhere in the project folder overrides the redirect url.

zfmodules.com

Answer 9 · 2015-01-25T08:50:30.000Z

OK, I need to figure out where that url is configured, and how to fix it; thanks!

On 25 January 2015 at 03:01:26, Marco Rieger (notifications@github.com) wrote:

@GeeH don't know where but the redirect to github looks on production like this https://github.com/login/oauth/authorize?client_id=e00c0cc9c5eab5a04653&redirect_uri=http%3A%2F%2Fzfmodules.com%2Fscn-social-auth%2Fhauth%3Fhauth.done%3DGitHub&response_type=code&scope=user%2C+public_repo%2C+ so the github application configured is not from the github account where u lookup the url or somewhere in the project folder overrides the redirect url.

—
Reply to this email directly or view it on GitHub.

Answer 10 · 2015-02-05T10:43:35.000Z

Hi @GeeH! Have you news for this problem?
Thanks!

Answer 11 · 2015-02-19T13:07:19.000Z

@heiglandreas

I understand this issue as this

Scenario 1

navigate to http://zfmodules.com
sign in with GitHub

GET /scn-social-auth/hauth?hauth.start=GitHub&hauth.time=1424353660 HTTP/1.1
Host: zfmodules.com
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
Connection: keep-alive
Cookie: PHPSESSID=foo
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_2) AppleWebKit/600.3.18 (KHTML, like Gecko) Version/8.0.3 Safari/600.3.18
Accept-Language: en-us
Referer: http://zfmodules.com/
Accept-Encoding: gzip, deflate

HTTP/1.1 302 Moved Temporarily
Server: nginx/1.2.1
Date: Thu, 19 Feb 2015 13:47:40 GMT
Content-Type: text/html; charset=UTF-8
Transfer-Encoding: chunked
Connection: keep-alive
Expires: Thu, 19 Nov 1981 08:52:00 GMT
Cache-Control: no-store, no-cache, must-revalidate, post-check=0, pre-check=0
Pragma: no-cache
Location: https://github.com/login/oauth/authorize?client_id=e00c0cc9c5eab5a04653&redirect_uri=http%3A%2F%2Fzfmodules.com%2Fscn-social-auth%2Fhauth%3Fhauth.done%3DGitHub&response_type=code&scope=user%2C+public_repo%2C+

get redirected to http://modules.zendframework.com with a redirect_uri_mismatch error

GET /?error=redirect_uri_mismatch&error_description=The+redirect_uri+MUST+match+the+registered+callback+URL+for+this+application.&error_uri=https%3A%2F%2Fdeveloper.github.com%2Fv3%2Foauth%2F%23redirect-uri-mismatch HTTP/1.1
Host: modules.zendframework.com
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
Connection: keep-alive
Cookie: PHPSESSID=foo
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_2) AppleWebKit/600.3.18 (KHTML, like Gecko) Version/8.0.3 Safari/600.3.18
Accept-Language: en-us
Referer: http://zfmodules.com/
Accept-Encoding: gzip, deflate

But we also have

Scenario 2

navigate to http://modules.zendframework.com
sign in with GitHub

GET /scn-social-auth/hauth?hauth.start=GitHub&hauth.time=1424353379 HTTP/1.1
Host: modules.zendframework.com
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
Connection: keep-alive
Cookie: PHPSESSID=foo
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_2) AppleWebKit/600.3.18 (KHTML, like Gecko) Version/8.0.3 Safari/600.3.18
Accept-Language: en-us
Referer: http://modules.zendframework.com/
Accept-Encoding: gzip, deflate

HTTP/1.1 302 Moved Temporarily
Date: Thu, 19 Feb 2015 13:42:59 GMT
Server: nginx/1.2.1
X-Frame-Options: SAMEORIGIN
Content-Type: text/html; charset=UTF-8
Expires: Thu, 19 Nov 1981 08:52:00 GMT
Cache-Control: no-store, no-cache, must-revalidate, post-check=0, pre-check=0
Pragma: no-cache
Location: https://github.com/login/oauth/authorize?client_id=e00c0cc9c5eab5a04653&redirect_uri=http%3A%2F%2Fzfmodules.com%2Fscn-social-auth%2Fhauth%3Fhauth.done%3DGitHub&response_type=code&scope=user%2C+public_repo%2C+
Content-Length: 0
Keep-Alive: timeout=15, max=99
Connection: Keep-Alive

get redirected to http://modules.zendframework.com with a redirect_uri_mismatch error

GET /?error=redirect_uri_mismatch&error_description=The+redirect_uri+MUST+match+the+registered+callback+URL+for+this+application.&error_uri=https%3A%2F%2Fdeveloper.github.com%2Fv3%2Foauth%2F%23redirect-uri-mismatch HTTP/1.1
Host: modules.zendframework.com
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
Connection: keep-alive
Cookie: PHPSESSID=foo
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_2) AppleWebKit/600.3.18 (KHTML, like Gecko) Version/8.0.3 Safari/600.3.18
Accept-Language: en-us
Referer: http://modules.zendframework.com/
Accept-Encoding: gzip, deflate

Not sure what's the actual deal with this.

What I can tell from Scenario 1 (redirects to http://modules.zendframework.com) and also from #296 (comment), at least Scenario 2 should work.

Answer 12 · 2015-02-19T13:23:31.000Z

just pointing out #296 (comment)

notice -> http%3A%2F%2Fzfmodules.com%2Fscn-social- [...]

Answer 13 · 2015-02-19T13:33:36.000Z

@ins0

Good catch, updating my comment above!

Answer 14 · 2015-02-19T13:50:23.000Z

@Ocramius @GeeH

Can you have a look? I know the two of you are really busy, but we need to get this sorted out!

Answer 15 · 2015-02-19T13:52:36.000Z

If you can tell me what I need to do in simple terms I will do it asap 🌵

Answer 16 · 2015-02-19T13:56:52.000Z

@GeeH Hard to say whitout access to the server. Can u confirm that the used Github Token in the Config files is equal to the Github Application where you edit the Callback Url? Maybe Config Cache?

// Edit
It looks like the Application currently used is registered over https://github.com/ZF-Commons

Answer 17 · 2015-02-19T14:03:19.000Z

@localheinz can I get you access to the server; would that work better?

Answer 18 · 2015-02-19T14:05:07.000Z

@GeeH just talked about this on IRC with @localheinz that would make things alot easier if andreas agrees 👍

Answer 19 · 2015-02-19T14:16:40.000Z

@localheinz I'll get this sorted with Kairos if you're ok with it

Answer 20 · 2015-02-20T12:11:12.000Z

@GeeH

Got access now!

However, what is apparent from #296 (comment):

Sorry to bug you with this, but can you please have a look at the GitHub Application setting again?
~~It should be http://modules.zendframework.com~~

EDIT

Actually, I have no idea which would be the first address you would go to,

So, no 🔑 at the moment!

Answer 21 · 2015-02-20T12:13:20.000Z

yes, I’ll bug @akrabat after his talk

On 20 February 2015 at 12:11:14, Andreas Möller (notifications@github.com) wrote:

@GeeH

Got access now!

However, what is apparent from #296 (comment):

Sorry to bug you with this, but can you please have a look at the GitHub Application setting again?

—
Reply to this email directly or view it on GitHub.

Answer 22 · 2015-02-20T12:13:59.000Z

@GeeH

Cool, you are 👑!

Answer 23 · 2015-02-20T12:14:52.000Z

🎉 !!! :D

Answer 24 · 2015-02-21T15:57:58.000Z

GeeH commented 10 years ago

Answer 25 · 2015-02-21T16:11:15.000Z

if the client id of the application is equal to e00c0cc9c5eab5a04653 we should ask for github support, this is too strange.

running out of suggest ideas, if on our side nothing is wrong as said

Answer 26 · 2015-02-21T16:20:29.000Z

I’ve confirmed the client ID and secret are correct

On 21 February 2015 at 16:11:18, Marco Rieger (notifications@github.com) wrote:

if the client id is equal to e00c0cc9c5eab5a04653 we should ask for github support, this is too strange

—
Reply to this email directly or view it on GitHub.

Answer 27 · 2015-02-23T17:43:22.000Z

Great news, thanks to @weierophinney we now have a new GitHub application under the realm of zendframework and are able to sign in, at least when going to http://zfmodules.com.

Looking into redirecting from http://modules.zendframework.com to http://zfmodules.com.

Answer 28 · 2015-02-23T17:50:50.000Z

Forgot to add some 🎉!

Answer 29 · 2015-02-23T17:52:14.000Z

🎉 beautifullll stuff!

Answer 30 · 2015-02-23T17:53:50.000Z

@weierophinney has also set up a redirect from http://modules.zendframework.com to http://zfmodules.com

Closing! 🍰