zendframework/zend-db

Add clear docblock to all classes and interfaces

Opened this issue · 4 comments

fadoe commented

Many classes and interfaces don't have docblocks. A developer and the IDE is not able to know which data should returned. Best example is the TableGatewayInterface.

Can I send an PR for this?

@fadoe
That would be great!

fadoe commented

I created a PR, but it is not completed now. I have for example a question about the StatementContainerInterface. Where is the best place for this questions? This issue or the pull request?

fadoe commented

I have a question to the DriverFeatureInterface.

The addFeature in the interface describes the feature as mixed, in Driver\Pdo\Pdo as AbstractFeature. getFeature returns in Driver\Pdo\Pdo AbstractFeature or false (see docblock). Is this a difference between the interface and the extended Pdo class? I think in the DriverFeatureInterface should it also AbstractFeature.

This repository has been closed and moved to laminas/laminas-db; a new issue has been opened at laminas/laminas-db#58.