Refactor of `Zend\Db\Sql` for 3.0.0
Opened this issue · 7 comments
This is a task for refactoring Zend\Db\Sql
using the type hints of PHP 7.2. You must work on the 3.0.0 branch.
If you change the API you should report it in the /3.0.0.md file.
Note: it's quite difficult to provide this code refactor without changing other classes. That means you should provide the refactoring without pass all the unit tests. In this phase is only important to have the unit tests running, so we you must focus only on fatal/parse errors.
I might take a look at it.
Thanks @guidofaecke, let me know if you need some help!
@guidofaecke Do you want any assistance?
You're more than welcome!
Here is what I got so far -> (https://github.com/guidofaecke/zend-db/tree/3.0.0_SQL_typeHints)
It's not a lot, I know, but I'm busy with some work related projects as well 😃
That's alright. Me working on a separate fork is unmanageable and PRs are overkill IMO. Would it be okay, if you grant me contribution access to your repo?
Done... I think... 😆
This repository has been closed and moved to laminas/laminas-db; a new issue has been opened at laminas/laminas-db#19.