zendframework/zend-mail

Error in HeaderValue (version 2.4.11 and 2.4.10) for PHP 5.3.26

BogMor opened this issue · 3 comments

BogMor commented

In the versions zend-mail 2.4.10 and 2.4.11 I found a problem for the version PHP 5.3.26, in the file src/Header/HeaderValue.php.
The line 90 is not compatible with this version 5.3.26
if ($lf !== 10 || ! in_array($sp, [9, 32], true)) {
This line was in 2.4.9
if ($lf !== 10 || $sp !== 32) {

A solution is to replace [9, 32] with array(9, 32)

glensc commented

committed the fix:
eventum@e00ac01

but can't make PR as zendframework/zend-mail has no base branch. afaik they have some master monolithic tree for 2.4 releases.

i created PR to self, commits can be seen there:
eventum#1

for maintainers, i guess they could add manually remote and pull from there.
or git cherry pick
or git am

this can be it:

wget https://github.com/glensc/zend-mail/pull/1.patch
git am 1.patch
glensc commented

btw, there are more 5.3 fixes i have in my maintenance branch:

  • fdd7e94 - irrelevant for production as fix is in tests

can be applied again with appending .patch to url and git am

glensc commented

this is fixed in 2.4.13, @BogMor or @weierophinney close this