zenml-io/mlstacks

Change AWS resources names in AWS Quickstarts in docs to not include underscores

Closed this issue · 2 comments

maxmynter commented

Hey mlstacks team,

I am working through the Quickstarts in the documentation and encountered an issue with the namings of the resources. Namely, AWS throws an error when it contains underscores:

RuntimeError: 
Error: validating S3 Bucket (zenml-quickstart_s3_bucket) name: 
only lowercase alphanumeric characters and hyphens allowed in 
"zenml-quickstart_s3_bucket"

  with aws_s3_bucket.zenml-artifact-store[0],
  on s3.tf line 2, in resource "aws_s3_bucket" 
"zenml-artifact-store":
   2: resource "aws_s3_bucket" "zenml-artifact-store" {

Suggestion

Adapt the two example .yaml files to use - instead of _ in the name properties.

I can make a PR for this, if there is nothing I have overlooked.

strickvl commented

Thank you for this. Just replacing with hyphens would be fine, and a PR would be welcomed!

  • 👍1
strickvl commented

Thanks for the quick fix!