[tbc-ge] Let integration work without loans
codeh4nter opened this issue ยท 20 comments
It's looks like a little bit weird that i can't use integration with tbc bank cause i have loan in account. Maybe it is possible to not throw error here and let app work with the bank but without loans support?
ZenPlugins/src/plugins/tbc-ge/index.ts
Line 21 in e8bfa60
Why TBC integration isn't fixed for more than 2 months?
It is not workink from 16.02.2024 (4 month!)
@skvav Please HALP!
Did create #759 to fix. Work on my side with loans, but require review.
Great, so we are waiting for final merge or?
The fix has beed merged already. Please check if the synchronization works.
Same "ะะต ัะดะฐะปะพัั ะฟะพะดะบะปััะธัั TBC Bank" version 67 (is it new version or previous?)
May be we need to wait for couple of days when 67 version changes to 68...
@iKOPKACtraxa I haven't tested it yet, I will keep you posted what results I will have
@aliakseiChynayeu Seems problem exists, I haven't tested yet but @iKOPKACtraxa check and no success. @skvav Maybe you can help here . Thanks
I haven't seen issue that was before - it looks like successfully sinchronized, but seems that there is another issue with plugin.
I did test it with simulator and get all accounts, but might be an issue with transactions parsing.
In the app I got an error:
[error] Error parsing title "***" in TransactionStandardMovementV2: Assertion failed: cant parse pos date . GEL
Looks like title was updated and it was unable to parse data correctly:
try {
this.transaction = transaction
const arr = transaction.title.split(',')
let invoice: { sum: number, instrument: string } | undefined
let sumIndex = 0
this.amount = transaction.amount
for (let i = 0; i < arr.length; i++) {
const str = arr[i].trim()
if (str.startsWith('แแแแฎแ') || str.startsWith('แขแ แแแแแฅแชแแแก แแแแฎแ')) {
sumIndex = i
// format is แแแแฎแ 10.00 USD
const invoiceStr = str.split(' ')
invoice = {
sum: Number.parseFloat(invoiceStr[invoiceStr.length - 2]),
instrument: invoiceStr[invoiceStr.length - 1]
}
const sign = Math.sign(this.amount)
if (sign === -1) {
invoice.sum = -invoice.sum
}
break
}
}
if (invoice !== undefined && !Number.isNaN(invoice.sum)) {
this.invoice = invoice
} else {
this.invoice = null
}
// arr from 0 to sumIndex
this.merchant = arr.slice(0, sumIndex).join(', ')
.replace('POS - ', '')
.replace('POS wallet - ', '')
.trim()
const dateTimeString = arr[sumIndex + 1].trim()
this.date = parsePOSDateString(dateTimeString)
this.cardNum = arr[arr.length - 1].trim().slice(-4)
this.mcc = Number.parseInt(arr[arr.length - 3].replace('MCC:', '').trim())
} catch ({ message }) {
console.error(transaction)
throw new Error(`Error parsing title "${transaction.title}" in TransactionStandardMovementV2: ${message}`)
}
but I see that title has ',' as separator :
DETAILS, AMOUNT GEL, DATE, DESCRIPTION, MCC: ****, VISA, VISA_NUMBER
Date in next format: Apr 10 2024 12:00AM
Based on the code amount is expeceted in next format:
if (str.startsWith('แแแแฎแ') || str.startsWith('แขแ แแแแแฅแชแแแก แแแแฎแ')) {
sumIndex = i
// format is แแแแฎแ 10.00 USD
but it returned as 10.00 GEL without prefix.
Hey guys, looks like it's down (again ๐ฅฒ). Can't connect for a week. I'm not a mobile myself so all I can do is complain
It is not workink from 16.02.2024
Version 68 not work too
@aliakseiChynayeu Hi, Maybe you can help us?
@Vakho89 During the last two weeks I think. As far as I can see there was a merge to master from this branch, maybe it affected somehow?
@aliakseiChynayeu @skvav Please help us :)
@Vakho89 During the last two weeks I think. As far as I can see there was a merge to master from this branch, maybe it affected somehow?
I just tried to connect and unfortunately without success. I have sent a log to developers. Cross fingers they can help us
@Hermesiss Hello, hope you are doing well. I just tried to connect TBC bank, and without a success. I have sent from application log to developers. Maybe it will be useful. Can you help us?