Change hasher from std to fxhasher

Question

Change hasher from std to fxhasher

Opened this issue 3 years ago · 4 comments

Answer 1 · 2022-06-07T14:31:57.000Z

Decided to change hasher from std to AHash instead of fxhasher, no idea about perf, havent tested

Answer 2 · 2022-06-08T06:44:16.000Z

Seems like there is some perf reduction on master, cant pin point what exactly is causing the perf degradation, but I am suspecting the use of Ahash is affecting it

❯ wrk -c100 -d15s -t8 http://localhost:8080/api/v1/timings/83139                                                          ─╯
Running 15s test @ http://localhost:8080/api/v1/timings/83139
  8 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency   474.88us    4.92ms 124.97ms   99.38%
    Req/Sec    87.78k     6.31k  111.67k    94.02%
  10532028 requests in 15.10s, 15.62GB read
  Non-2xx or 3xx responses: 56
Requests/sec: 697471.72
Transfer/sec:      1.03GB

Answer 3 · 2022-06-08T06:45:39.000Z

Regarding this issue, I think we should just parameterize the hashmaps rather than using the different hasher

Answer 4 · 2022-06-19T12:16:25.000Z

Using Fxhash is causing this problem

Requested application data is not configured correctly. View/enable debug logs for more details.