zephyrproject-rtos/west

west update should exit with none-zero code if update failed

Hoohaha opened this issue · 5 comments

Hoohaha commented

Hi there,

west update command always exit zero code even if there have projects update failed.
It should return none-zero code if something wrong.
This is useful in CI build system to check the result of update.

Reproduce Steps (windows)

  1. Run command:
west update
  1. Press ctrl+c
  2. Check return code
ehco %ERRORLEVEL%
marc-hb commented

I'm not sure Ctrl-C on Windows lets west decide what the return code is.

Please try the following:

  • Do not use Ctrl-C, corrupt the SHA1 of one project in the west.yml manifest and run west update. Share what the %ERRORLEVEL% is. I justed tested that on Linux and it's not zero. You can also try corrupting a git remote.

  • On Windows, use Ctrl-C with other programs (sleep?) and share what the %ERRORLEVEL% is.

Hoohaha commented
  • Do not use Ctrl-C, corrupt the SHA1 of one project in the west.yml manifest and run west update. Share what the %ERRORLEVEL% is. I justed tested that on Linux and it's not zero. You can also try corrupting a git remote.

I did the testing as you described, west returned 1 as expected.
My bad, it's not an issue.
But no idea why west returned with CTRL-C.

Anyway, thank you Marc

marc-hb commented

But no idea why west returned with CTRL-C.

Have a look at new #636

marc-hb commented

Ctrl-C fix merged, @Hoohaha can you please test again?

Hoohaha commented

@marc-hb Thank you, tested with latest commit, returncode is none-zero if ctrl+c