Fix SonarCloud Issues

Question

Fix SonarCloud Issues

zerasul opened this issue 3 years ago · 5 comments

zerasul commented 3 years ago

Fix some sonar cloud smell codes:

https://sonarcloud.io/project/issues?id=genesis-code-project&resolved=false&types=CODE_SMELL

zerasul commented 3 years ago

sure!

Answer 1 · 2021-09-30T03:20:00.000Z

@zerasul Hey! May I please be assigned this under hacktoberfest?

Answer 2 · 2021-09-30T22:14:52.000Z

Hi again @zerasul All I have to do is make sure it passes the npm run test command and SonarCloud quality gate? Are there any other tests that I must run? Also, what do you use to format your code?

Answer 3 · 2021-10-01T05:44:16.000Z

Hi @crypto-cmd in this case only you have to do is fix the smell codes reported by sonar.

We have another issue to fix the coverage report #74 as you can see in sonarcloud the coverage is 0.0%.

Answer 4 · 2021-10-01T06:06:37.000Z

@zerasul Gotcha! I will create a pull request soon.